V3 S5 : graphe documentaire + doublons + collections

Backend : resource_links + scan_session_id (000021), réconciliation
déterministe (same_scan outbox, doublons SHA-256 à l'upload + backfill,
same_issuer/référence via faits effectifs, verdicts préservés, élagage
auto), GET /files/:id/relations + verdict (owner-only),
GET /duplicates (groupes + gain récupérable). Tests service + handlers
+ migrations.

Mobile (Room v22) : links + collections, scanSessionId dans les creates
de scan, LinksRepository (sync + verdicts REST), « Voir aussi » dans la
fiche (verdict infirmer/re-confirmer), écran Doublons (garder le plus
récent), collections locales (sauver/rejouer/supprimer). FR/EN.

Contrat docs/api-v1.md (/relations, pas /links — pris par le partage),
V3.md (S5 livré, version_of non matérialisé).
This commit is contained in:
venture
2026-09-26 11:16:35 +02:00
parent 2d984fd665
commit 37dc36f1f2
66 changed files with 3933 additions and 34 deletions
+252
View File
@@ -0,0 +1,252 @@
package service
import (
"errors"
"testing"
"github.com/kazier/backend/repository"
)
func mustLinkFile(t *testing.T, s *Resources, userID, name string) string {
t.Helper()
id := repository.NewID()
if err := s.Repository.Resources.InsertFile(userID, id, name, "", 0, nil, nil); err != nil {
t.Fatalf("insert %q: %v", name, err)
}
return id
}
func relationTypes(rels []RelationDTO) map[string]int {
out := map[string]int{}
for _, r := range rels {
out[r.Type]++
}
return out
}
func TestSameScanViaOutbox(t *testing.T) {
s := newServiceStore(t)
userID := mustCreateUser(t, s.Repository, "links-scan")
device := mustRegisterDevice(t, s.Repository, "d0000000000000000000000000000001")
session := repository.NewID()
page1 := repository.NewID()
page2 := repository.NewID()
create := func(opID, resID, name string) {
t.Helper()
res, err := s.ApplyBatch(userID, device, []SyncOperation{
syncOp(opID, resID, OpCreateResource, "file", map[string]any{
"name": resID + "-" + name, "scanSessionId": session,
}),
})
if err != nil {
t.Fatalf("apply: %v", err)
}
if res.Applied != 1 || res.Failed != nil {
t.Fatalf("create %s: %+v", name, res)
}
}
create(repository.NewID(), page1, "p1.png")
create(repository.NewID(), page2, "p2.png")
rels, err := s.ListRelations(userID, page1)
if err != nil {
t.Fatalf("relations: %v", err)
}
if relationTypes(rels)[repository.LinkSameScan] != 1 || rels[0].OtherID != page2 {
t.Fatalf("same_scan manquant: %+v", rels)
}
if rels[0].Confidence != 1.0 || rels[0].CreatedBy != "auto" {
t.Fatalf("arête same_scan inattendue: %+v", rels[0])
}
// Session invalide → halt INVALID_REQUEST (pas d'écriture partielle).
res, err := s.ApplyBatch(userID, device, []SyncOperation{
syncOp(repository.NewID(), repository.NewID(), OpCreateResource, "file", map[string]any{
"name": "bad.png", "scanSessionId": "nope",
}),
})
if err != nil {
t.Fatalf("apply: %v", err)
}
if res.Failed == nil || res.Failed.Code != "INVALID_REQUEST" {
t.Fatalf("session invalide doit halter: %+v", res)
}
}
func TestDuplicateOfViaUploadHash(t *testing.T) {
s := newServiceStore(t)
userID := mustCreateUser(t, s.Repository, "links-dupe")
a, err := s.Upload(userID, multipartFileHeader(t, "a.txt", []byte("meme-contenu")), "", "")
if err != nil {
t.Fatalf("upload a: %v", err)
}
b, err := s.Upload(userID, multipartFileHeader(t, "b.txt", []byte("meme-contenu")), "", "")
if err != nil {
t.Fatalf("upload b: %v", err)
}
rels, err := s.ListRelations(userID, a.ID)
if err != nil {
t.Fatalf("relations: %v", err)
}
if relationTypes(rels)[repository.LinkDuplicateOf] != 1 || rels[0].OtherID != b.ID {
t.Fatalf("duplicate_of manquant: %+v", rels)
}
// Contenu différent → pas de doublon.
c, err := s.Upload(userID, multipartFileHeader(t, "c.txt", []byte("autre-contenu")), "", "")
if err != nil {
t.Fatalf("upload c: %v", err)
}
relsC, err := s.ListRelations(userID, c.ID)
if err != nil {
t.Fatalf("relations c: %v", err)
}
if len(relsC) != 0 {
t.Fatalf("faux doublon: %+v", relsC)
}
}
func TestSameIssuerViaFacts(t *testing.T) {
s, ex := newExtractStore(t)
userID := mustCreateUser(t, s.Repository, "links-issuer")
f1 := mustLinkFile(t, s, userID, "f1.pdf")
f2 := mustLinkFile(t, s, userID, "f2.pdf")
if err := ex.ProcessText(userID, f1, "EDF\nFacture 10,00 €\n"); err != nil {
t.Fatalf("extract f1: %v", err)
}
if err := ex.ProcessText(userID, f2, "EDF\nFacture 20,00 €\n"); err != nil {
t.Fatalf("extract f2: %v", err)
}
rels, err := s.ListRelations(userID, f1)
if err != nil {
t.Fatalf("relations: %v", err)
}
if relationTypes(rels)[repository.LinkSameIssuer] != 1 {
t.Fatalf("same_issuer manquant: %+v", rels)
}
// Correction de l'émetteur → l'arête disparaît (prune auto).
if err := s.CorrectFacts(userID, f2, []FactDTO{{FactType: "issuer", ValueText: "ENGIE", Confidence: 1}}); err != nil {
t.Fatalf("correct: %v", err)
}
rels, err = s.ListRelations(userID, f1)
if err != nil {
t.Fatalf("relations 2: %v", err)
}
if relationTypes(rels)[repository.LinkSameIssuer] != 0 {
t.Fatalf("arête périmée non élaguée: %+v", rels)
}
}
func TestLinkVerdict(t *testing.T) {
s := newServiceStore(t)
userID := mustCreateUser(t, s.Repository, "links-verdict")
other := mustCreateUser(t, s.Repository, "links-verdict-x")
device := mustRegisterDevice(t, s.Repository, "d0000000000000000000000000000002")
session := repository.NewID()
p1, p2 := repository.NewID(), repository.NewID()
for _, id := range []string{p1, p2} {
res, err := s.ApplyBatch(userID, device, []SyncOperation{
syncOp(repository.NewID(), id, OpCreateResource, "file", map[string]any{
"name": id, "scanSessionId": session,
}),
})
if err != nil || res.Applied != 1 || res.Failed != nil {
t.Fatalf("create %s: %+v %v", id, res, err)
}
}
// Invalider : l'arête reste (confiance 0, verdict user) mais ne bloque rien.
if err := s.LinkVerdict(userID, p1, p2, repository.LinkSameScan, false); err != nil {
t.Fatalf("verdict: %v", err)
}
rels, _ := s.ListRelations(userID, p1)
if len(rels) != 1 || rels[0].Confidence != 0 || rels[0].CreatedBy != "user" {
t.Fatalf("verdict infirme inattendu: %+v", rels)
}
// Re-reconcile ne ressuscite pas l'arête invalidée.
rels, _ = s.ListRelations(userID, p1)
if len(rels) != 1 || rels[0].Confidence != 0 {
t.Fatalf("arête invalidée ressuscitée: %+v", rels)
}
// Re-confirmer : retour à 1.0 user.
if err := s.LinkVerdict(userID, p1, p2, repository.LinkSameScan, true); err != nil {
t.Fatalf("re-verdict: %v", err)
}
rels, _ = s.ListRelations(userID, p1)
if len(rels) != 1 || rels[0].Confidence != 1.0 || rels[0].CreatedBy != "user" {
t.Fatalf("re-verdict inattendu: %+v", rels)
}
// Type inconnu → erreur 400-candidate ; paire réflexive idem.
if err := s.LinkVerdict(userID, p1, p2, "copains", true); !errors.Is(err, ErrInvalidLinkType) {
t.Fatalf("type inconnu : attendu ErrInvalidLinkType, got %v", err)
}
if err := s.LinkVerdict(userID, p1, p1, repository.LinkSameScan, true); !errors.Is(err, ErrInvalidLinkType) {
t.Fatalf("paire réflexive : attendu ErrInvalidLinkType, got %v", err)
}
// Autrui → NOT_FOUND (pas d'oracle).
foreign := mustLinkFile(t, s, other, "x.pdf")
if err := s.LinkVerdict(other, foreign, p1, repository.LinkSameScan, true); err != repository.ErrNotFound {
t.Fatalf("verdict trans-compte : attendu NOT_FOUND, got %v", err)
}
if _, err := s.ListRelations(other, p1); err != repository.ErrNotFound {
t.Fatalf("lecture trans-compte : attendu NOT_FOUND, got %v", err)
}
}
func TestListDuplicates(t *testing.T) {
s := newServiceStore(t)
userID := mustCreateUser(t, s.Repository, "links-dupes")
other := mustCreateUser(t, s.Repository, "links-dupes-x")
a, err := s.Upload(userID, multipartFileHeader(t, "a.txt", []byte("doublon")), "", "")
if err != nil {
t.Fatalf("upload a: %v", err)
}
b, err := s.Upload(userID, multipartFileHeader(t, "b.txt", []byte("doublon")), "", "")
if err != nil {
t.Fatalf("upload b: %v", err)
}
if _, err := s.Upload(userID, multipartFileHeader(t, "c.txt", []byte("unique-contenu")), "", ""); err != nil {
t.Fatalf("upload c: %v", err)
}
// Même contenu chez un autre compte : pas mon doublon.
if _, err := s.Upload(other, multipartFileHeader(t, "z.txt", []byte("doublon")), "", ""); err != nil {
t.Fatalf("upload other: %v", err)
}
groups, err := s.ListDuplicates(userID)
if err != nil {
t.Fatalf("duplicates: %v", err)
}
if len(groups) != 1 || groups[0].Count != 2 {
t.Fatalf("groupes inattendus: %+v", groups)
}
g := groups[0]
if g.TotalBytes != 14 || g.ReclaimableBytes != 7 {
t.Fatalf("tailles inattendues: %+v", g)
}
ids := map[string]bool{}
for _, f := range g.Files {
ids[f.ID] = true
}
if !ids[a.ID] || !ids[b.ID] {
t.Fatalf("membres inattendus: %+v", g.Files)
}
// Compte propre → [] (jamais null).
empty, err := s.ListDuplicates(other)
if err != nil {
t.Fatalf("duplicates other: %v", err)
}
if len(empty) != 0 {
t.Fatalf("compte sans doublon: %+v", empty)
}
}