fix backend audit findings (auth, upload, sync, data, ocr, contract)
CI / lint-backend (push) Failing after 1m39s
CI / lint-mobile (push) Canceled after 11m8s
CI / test-backend (push) Canceled after 0s
CI / test-mobile (push) Canceled after 0s
CI / build-backend (push) Canceled after 0s
CI / docker (push) Canceled after 0s
CI / lint-backend (push) Failing after 1m39s
CI / lint-mobile (push) Canceled after 11m8s
CI / test-backend (push) Canceled after 0s
CI / test-mobile (push) Canceled after 0s
CI / build-backend (push) Canceled after 0s
CI / docker (push) Canceled after 0s
This commit is contained in:
@@ -208,6 +208,41 @@ func TestApplyBatchMoveToMissingFolder(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestApplyBatchMoveIntoDescendantRejected(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
userID := mustCreateUser(t, s.Repository, "sync-move-cycle")
|
||||
deviceID := mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
parentID := repository.NewID()
|
||||
childID := repository.NewID()
|
||||
if _, err := s.ApplyBatch(userID, deviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), parentID, OpCreateResource, "folder", map[string]any{"name": "parent"}),
|
||||
syncOp(repository.NewID(), childID, OpCreateResource, "folder", map[string]any{"name": "child", "parentResourceId": parentID}),
|
||||
}); err != nil {
|
||||
t.Fatalf("apply create parent+child: %v", err)
|
||||
}
|
||||
|
||||
// Déplacer le parent dans son propre enfant créerait un cycle : halt.
|
||||
result, err := s.ApplyBatch(userID, deviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), parentID, OpMoveResource, "folder", map[string]any{"toFolderResourceId": childID}),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("ApplyBatch: %v", err)
|
||||
}
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "INVALID_REQUEST" {
|
||||
t.Fatalf("move parent→enfant: attendu applied=0 INVALID_REQUEST, got %+v", result)
|
||||
}
|
||||
|
||||
// Le parent est toujours à la racine : aucun cycle créé.
|
||||
got, err := s.Repository.Resources.GetParentID(parentID)
|
||||
if err != nil {
|
||||
t.Fatalf("GetParentID: %v", err)
|
||||
}
|
||||
if got != "" {
|
||||
t.Errorf("parent déplacé malgré le rejet: parent=%q", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestApplyBatchRejectsInvalidPayloadJSON(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
userID := mustCreateUser(t, s.Repository, "sync-badpayload")
|
||||
@@ -1146,15 +1181,16 @@ func TestUpdateMetadataRequiresEditor(t *testing.T) {
|
||||
t.Errorf("viewer update: attendu applied=0 NOT_FOUND, got %+v", result)
|
||||
}
|
||||
|
||||
// Stranger (no access) → no-op terminal (absent semantics), no failure.
|
||||
// Stranger (no access) → NOT_FOUND halt (A8 : pas de no-op silencieux ;
|
||||
// un rename qui n'a rien renommé est une désync, le halt l'expose).
|
||||
result, err = s.ApplyBatch(strangerID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileID, OpUpdateMetadata, "file", map[string]any{"name": "sneak.txt"}),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("stranger update: %v", err)
|
||||
}
|
||||
if result.Applied != 1 || result.Failed != nil {
|
||||
t.Errorf("stranger update: attendu applied=1 aucun échec, got %+v", result)
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "NOT_FOUND" {
|
||||
t.Errorf("stranger update: attendu applied=0 NOT_FOUND, got %+v", result)
|
||||
}
|
||||
row, err = s.Repo.GetFile(ownerID, fileID)
|
||||
if err != nil || row.Name != "renamed.txt" {
|
||||
@@ -1179,15 +1215,16 @@ func TestMoveAndDeleteOwnerOnly(t *testing.T) {
|
||||
t.Fatalf("create + share: %v", err)
|
||||
}
|
||||
|
||||
// Editor tries to move the shared file → no-op (owner-only), nothing moves.
|
||||
// Editor tries to move the shared file → NOT_FOUND halt (A8 : move
|
||||
// owner-only, pas de applied silencieux).
|
||||
result, err := s.ApplyBatch(granteeID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileID, OpMoveResource, "file", map[string]any{"toFolderResourceId": targetID}),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("grantee move: %v", err)
|
||||
}
|
||||
if result.Applied != 1 || result.Failed != nil {
|
||||
t.Fatalf("grantee move: applied=%d failed=%+v", result.Applied, result.Failed)
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "NOT_FOUND" {
|
||||
t.Fatalf("grantee move: attendu applied=0 NOT_FOUND, got %+v", result)
|
||||
}
|
||||
row, err := s.Repo.GetFile(ownerID, fileID)
|
||||
if err != nil {
|
||||
@@ -1197,17 +1234,254 @@ func TestMoveAndDeleteOwnerOnly(t *testing.T) {
|
||||
t.Errorf("fichier déplacé par un non-owner: folderId=%q, attendu racine", row.FolderID)
|
||||
}
|
||||
|
||||
// Editor tries to delete the shared file → no-op, still present for owner.
|
||||
// Editor tries to delete the shared file → NOT_FOUND halt (A8), still
|
||||
// present for owner.
|
||||
result, err = s.ApplyBatch(granteeID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileID, OpDeleteResource, "file", map[string]any{}),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("grantee delete: %v", err)
|
||||
}
|
||||
if result.Applied != 1 || result.Failed != nil {
|
||||
t.Fatalf("grantee delete: applied=%d failed=%+v", result.Applied, result.Failed)
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "NOT_FOUND" {
|
||||
t.Fatalf("grantee delete: attendu applied=0 NOT_FOUND, got %+v", result)
|
||||
}
|
||||
if _, err := s.Repo.GetFile(ownerID, fileID); err != nil {
|
||||
t.Errorf("fichier supprimé par un non-owner: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// --- LOT 3 : rejeu, payload_hash, liens idempotents, sémantiques A8 ---
|
||||
|
||||
func TestApplyBatchReplaySameOpIsIdempotent(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
userID := mustCreateUser(t, s.Repository, "replay-owner")
|
||||
deviceID := mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
fileID := repository.NewID()
|
||||
opID := repository.NewID()
|
||||
op := syncOp(opID, fileID, OpCreateResource, "file", map[string]any{"name": "x.txt"})
|
||||
|
||||
result, err := s.ApplyBatch(userID, deviceID, []SyncOperation{op})
|
||||
if err != nil || result.Applied != 1 || result.Failed != nil {
|
||||
t.Fatalf("apply 1: applied=%d failed=%+v err=%v", result.Applied, result.Failed, err)
|
||||
}
|
||||
// Rejeu à l'identique (même operation_id, même payload) → skip succès.
|
||||
result, err = s.ApplyBatch(userID, deviceID, []SyncOperation{op})
|
||||
if err != nil || result.Applied != 1 || result.Failed != nil {
|
||||
t.Errorf("rejeu identique: applied=%d failed=%+v err=%v", result.Applied, result.Failed, err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestApplyBatchReplayMutatedPayloadRejected(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
userID := mustCreateUser(t, s.Repository, "replay-mut")
|
||||
deviceID := mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
fileID := repository.NewID()
|
||||
opID := repository.NewID()
|
||||
first := syncOp(opID, fileID, OpCreateResource, "file", map[string]any{"name": "x.txt"})
|
||||
if _, err := s.ApplyBatch(userID, deviceID, []SyncOperation{first}); err != nil {
|
||||
t.Fatalf("apply 1: %v", err)
|
||||
}
|
||||
// Même (device, operation_id), payload muté → INVALID_REQUEST halt (A9),
|
||||
// pas de skip silencieux.
|
||||
mutated := syncOp(opID, fileID, OpCreateResource, "file", map[string]any{"name": "y.txt"})
|
||||
result, err := s.ApplyBatch(userID, deviceID, []SyncOperation{mutated})
|
||||
if err != nil {
|
||||
t.Fatalf("ApplyBatch: %v", err)
|
||||
}
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "INVALID_REQUEST" {
|
||||
t.Errorf("payload muté: attendu applied=0 INVALID_REQUEST, got %+v", result)
|
||||
}
|
||||
// Même opération rejouée sous un autre type → rejet aussi.
|
||||
retyped := syncOp(opID, fileID, OpDeleteResource, "file", map[string]any{})
|
||||
result, err = s.ApplyBatch(userID, deviceID, []SyncOperation{retyped})
|
||||
if err != nil {
|
||||
t.Fatalf("ApplyBatch: %v", err)
|
||||
}
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "INVALID_REQUEST" {
|
||||
t.Errorf("type muté: attendu applied=0 INVALID_REQUEST, got %+v", result)
|
||||
}
|
||||
}
|
||||
|
||||
func TestApplyBatchReplayWhitespaceEquivalentPayload(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
userID := mustCreateUser(t, s.Repository, "replay-ws")
|
||||
deviceID := mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
fileID := repository.NewID()
|
||||
opID := repository.NewID()
|
||||
first := syncOp(opID, fileID, OpCreateResource, "file", map[string]any{"name": "x.txt"})
|
||||
if _, err := s.ApplyBatch(userID, deviceID, []SyncOperation{first}); err != nil {
|
||||
t.Fatalf("apply 1: %v", err)
|
||||
}
|
||||
// Même objet, sérialisation différente (espaces) → hash canonique égal → skip.
|
||||
second := SyncOperation{
|
||||
OperationID: opID,
|
||||
ResourceID: strp(fileID),
|
||||
ResourceType: strp("file"),
|
||||
Operation: OpCreateResource,
|
||||
Payload: json.RawMessage(`{ "name" : "x.txt" }`),
|
||||
}
|
||||
result, err := s.ApplyBatch(userID, deviceID, []SyncOperation{second})
|
||||
if err != nil || result.Applied != 1 || result.Failed != nil {
|
||||
t.Errorf("rejeu équivalent: applied=%d failed=%+v err=%v", result.Applied, result.Failed, err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateLinkReplayIdempotent(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
ownerID := mustCreateUser(t, s.Repository, "linkreplay-owner")
|
||||
mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
fileID := repository.NewID()
|
||||
if _, err := s.ApplyBatch(ownerID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileID, OpCreateResource, "file", map[string]any{"name": "x.txt"}),
|
||||
}); err != nil {
|
||||
t.Fatalf("create: %v", err)
|
||||
}
|
||||
|
||||
token := repository.NewID()
|
||||
link := func(opID string) SyncOperation {
|
||||
return syncOp(opID, fileID, OpCreateLink, "file", map[string]any{
|
||||
"token": token,
|
||||
"access": "viewer",
|
||||
})
|
||||
}
|
||||
// Premier create_link.
|
||||
if _, err := s.ApplyBatch(ownerID, shareTestDeviceID, []SyncOperation{link(repository.NewID())}); err != nil {
|
||||
t.Fatalf("create link 1: %v", err)
|
||||
}
|
||||
// Rejeu même token, même ressource, même owner (nouvel operation_id) → succès.
|
||||
result, err := s.ApplyBatch(ownerID, shareTestDeviceID, []SyncOperation{link(repository.NewID())})
|
||||
if err != nil || result.Applied != 1 || result.Failed != nil {
|
||||
t.Errorf("rejeu lien identique: applied=%d failed=%+v err=%v", result.Applied, result.Failed, err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateLinkTokenReuseConflict(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
ownerID := mustCreateUser(t, s.Repository, "linkconf-owner")
|
||||
mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
fileA := repository.NewID()
|
||||
fileB := repository.NewID()
|
||||
if _, err := s.ApplyBatch(ownerID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileA, OpCreateResource, "file", map[string]any{"name": "a.txt"}),
|
||||
syncOp(repository.NewID(), fileB, OpCreateResource, "file", map[string]any{"name": "b.txt"}),
|
||||
}); err != nil {
|
||||
t.Fatalf("create: %v", err)
|
||||
}
|
||||
|
||||
token := repository.NewID()
|
||||
if _, err := s.ApplyBatch(ownerID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileA, OpCreateLink, "file", map[string]any{"token": token, "access": "viewer"}),
|
||||
}); err != nil {
|
||||
t.Fatalf("create link: %v", err)
|
||||
}
|
||||
// Même token vers une AUTRE ressource du même owner → NAME_CONFLICT (#3).
|
||||
result, err := s.ApplyBatch(ownerID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileB, OpCreateLink, "file", map[string]any{"token": token, "access": "viewer"}),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("ApplyBatch: %v", err)
|
||||
}
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "NAME_CONFLICT" {
|
||||
t.Errorf("token réutilisé: attendu applied=0 NAME_CONFLICT, got %+v", result)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateLinkTokenOwnerMismatch(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
owner1 := mustCreateUser(t, s.Repository, "linkown-1")
|
||||
owner2 := mustCreateUser(t, s.Repository, "linkown-2")
|
||||
mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
fileA := repository.NewID()
|
||||
fileB := repository.NewID()
|
||||
if _, err := s.ApplyBatch(owner1, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileA, OpCreateResource, "file", map[string]any{"name": "a.txt"}),
|
||||
}); err != nil {
|
||||
t.Fatalf("create A: %v", err)
|
||||
}
|
||||
if _, err := s.ApplyBatch(owner2, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileB, OpCreateResource, "file", map[string]any{"name": "b.txt"}),
|
||||
}); err != nil {
|
||||
t.Fatalf("create B: %v", err)
|
||||
}
|
||||
|
||||
token := repository.NewID()
|
||||
if _, err := s.ApplyBatch(owner1, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileA, OpCreateLink, "file", map[string]any{"token": token, "access": "viewer"}),
|
||||
}); err != nil {
|
||||
t.Fatalf("create link: %v", err)
|
||||
}
|
||||
// Même token, autre owner → NAME_CONFLICT (#3).
|
||||
result, err := s.ApplyBatch(owner2, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileB, OpCreateLink, "file", map[string]any{"token": token, "access": "viewer"}),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("ApplyBatch: %v", err)
|
||||
}
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "NAME_CONFLICT" {
|
||||
t.Errorf("token d'autrui: attendu applied=0 NAME_CONFLICT, got %+v", result)
|
||||
}
|
||||
}
|
||||
|
||||
func TestUpdateMetadataAbsentHalts(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
userID := mustCreateUser(t, s.Repository, "ren-absent")
|
||||
deviceID := mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
// update_metadata sur ressource inexistante → NOT_FOUND halt (A8).
|
||||
result, err := s.ApplyBatch(userID, deviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), repository.NewID(), OpUpdateMetadata, "file", map[string]any{"name": "ghost.txt"}),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("ApplyBatch: %v", err)
|
||||
}
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "NOT_FOUND" {
|
||||
t.Errorf("rename absent: attendu applied=0 NOT_FOUND, got %+v", result)
|
||||
}
|
||||
}
|
||||
|
||||
func TestMoveForeignHalts(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
ownerID := mustCreateUser(t, s.Repository, "movef-owner")
|
||||
outsiderID := mustCreateUser(t, s.Repository, "movef-outsider")
|
||||
mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
fileID := repository.NewID()
|
||||
targetID := repository.NewID()
|
||||
if _, err := s.ApplyBatch(ownerID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileID, OpCreateResource, "file", map[string]any{"name": "x.txt"}),
|
||||
syncOp(repository.NewID(), targetID, OpCreateResource, "folder", map[string]any{"name": "t"}),
|
||||
}); err != nil {
|
||||
t.Fatalf("create: %v", err)
|
||||
}
|
||||
// Move d'une ressource d'autrui (jamais partagée) → NOT_FOUND halt.
|
||||
result, err := s.ApplyBatch(outsiderID, shareTestDeviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), fileID, OpMoveResource, "file", map[string]any{"toFolderResourceId": targetID}),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("ApplyBatch: %v", err)
|
||||
}
|
||||
if result.Applied != 0 || result.Failed == nil || result.Failed.Code != "NOT_FOUND" {
|
||||
t.Errorf("move étranger: attendu applied=0 NOT_FOUND, got %+v", result)
|
||||
}
|
||||
}
|
||||
|
||||
func TestDeleteAbsentIsIdempotentNoop(t *testing.T) {
|
||||
s := newServiceStore(t)
|
||||
userID := mustCreateUser(t, s.Repository, "delabsent-owner")
|
||||
deviceID := mustRegisterDevice(t, s.Repository, shareTestDeviceID)
|
||||
|
||||
// Delete d'une ressource sans ligne vivante → no-op idempotent (état
|
||||
// terminal déjà atteint), pas de halt.
|
||||
result, err := s.ApplyBatch(userID, deviceID, []SyncOperation{
|
||||
syncOp(repository.NewID(), repository.NewID(), OpDeleteResource, "file", map[string]any{}),
|
||||
})
|
||||
if err != nil || result.Applied != 1 || result.Failed != nil {
|
||||
t.Errorf("delete absent: applied=%d failed=%+v err=%v", result.Applied, result.Failed, err)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user