V3 S3 : correction des faits (fiche document + correct_facts)

Backend : CorrectFacts (editor+, validation Go -> 400 jamais 500),
op outbox correct_facts (full-replace jeu user), PATCH
/files/:id/facts (renvoie jeu complet). Tests service + sync + handlers.

Mobile (Room v20) : table resource_facts + FactsDao, FactsRepository
(sync remplace-en-bloc, correction optimiste + outbox atomique),
fiche « Ce qu'on a compris » sur le viewer (chips, suggéré grisé,
édition par type, reset auto), bouton viewer si processed, FR/EN.

Contrat docs/api-v1.md, V3.md (S1-S3 livrés, FTS -> v21).
This commit is contained in:
venture
2026-09-26 10:28:33 +02:00
parent 95b4cf79cf
commit ac8bd9acb4
45 changed files with 2554 additions and 15 deletions
+167
View File
@@ -1,6 +1,7 @@
package service
import (
"errors"
"testing"
"github.com/kazier/backend/repository"
@@ -194,3 +195,169 @@ func TestBackfill(t *testing.T) {
t.Fatalf("backfill 2 = %d, attendu 0", n)
}
}
func correctDTO(factType, valueText string) FactDTO {
return FactDTO{FactType: factType, ValueText: valueText, Confidence: 1.0}
}
func TestCorrectFactsReplacesUserSet(t *testing.T) {
s, ex := newExtractStore(t)
userID := mustCreateUser(t, s.Repository, "extract-correct")
fileID := repository.NewID()
if err := s.Repository.Resources.InsertFile(userID, fileID, "facture.pdf", "", 0, nil, nil); err != nil {
t.Fatalf("insert: %v", err)
}
if err := ex.ProcessText(fileID, extractCorpus); err != nil {
t.Fatalf("process: %v", err)
}
// Correction : l'émetteur auto est faux, l'utilisateur le fixe.
if err := s.CorrectFacts(userID, fileID, []FactDTO{correctDTO("issuer", "Vrai Fournisseur")}); err != nil {
t.Fatalf("correct: %v", err)
}
facts, err := s.GetFacts(userID, fileID)
if err != nil {
t.Fatalf("get facts: %v", err)
}
var userIssuer, autoIssuer int
for _, f := range facts {
if f.FactType == "issuer" && f.Origin == "user" && f.ValueText == "Vrai Fournisseur" {
userIssuer++
}
if f.FactType == "issuer" && f.Origin == "auto" {
autoIssuer++
}
}
if userIssuer != 1 {
t.Fatalf("correction user manquante: %+v", facts)
}
if autoIssuer == 0 {
t.Error("l'auto doit survivre à côté du user (les deux sont lus, user d'abord)")
}
// Deuxième correction (jeu vide) : efface les corrections, garde l'auto.
if err := s.CorrectFacts(userID, fileID, nil); err != nil {
t.Fatalf("clear corrections: %v", err)
}
facts, _ = s.GetFacts(userID, fileID)
for _, f := range facts {
if f.Origin == "user" {
t.Fatalf("corrections restantes: %+v", facts)
}
}
if len(facts) == 0 {
t.Fatal("l'auto doit survivre à l'effacement des corrections")
}
}
func TestCorrectFactsValidation(t *testing.T) {
s, _ := newExtractStore(t)
userID := mustCreateUser(t, s.Repository, "extract-correct-val")
fileID := repository.NewID()
if err := s.Repository.Resources.InsertFile(userID, fileID, "doc.pdf", "", 0, nil, nil); err != nil {
t.Fatalf("insert: %v", err)
}
num := 12.5
cases := []struct {
name string
facts []FactDTO
}{
{"type inconnu", []FactDTO{{FactType: "couleur", ValueText: "bleu"}}},
{"confiance hors bornes", []FactDTO{{FactType: "issuer", ValueText: "X", Confidence: 2}}},
{"date non ISO", []FactDTO{{FactType: "date", ValueDate: "12/03/2026"}}},
{"sans valeur", []FactDTO{{FactType: "issuer"}}},
}
for _, tc := range cases {
if err := s.CorrectFacts(userID, fileID, tc.facts); err == nil {
t.Errorf("%s : erreur attendue", tc.name)
} else if !errors.Is(err, ErrInvalidFact) {
t.Errorf("%s : attendu ErrInvalidFact, got %v", tc.name, err)
}
}
// Valides : date ISO + montant numérique.
if err := s.CorrectFacts(userID, fileID, []FactDTO{
{FactType: "due_date", ValueDate: "2026-04-12"},
{FactType: "amount", ValueNum: &num},
}); err != nil {
t.Fatalf("faits valides rejetés: %v", err)
}
}
func TestCorrectFactsScope(t *testing.T) {
s, _ := newExtractStore(t)
owner := mustCreateUser(t, s.Repository, "extract-corr-o")
viewer := mustCreateUser(t, s.Repository, "extract-corr-v")
fileID := repository.NewID()
if err := s.Repository.Resources.InsertFile(owner, fileID, "doc.pdf", "", 0, nil, nil); err != nil {
t.Fatalf("insert: %v", err)
}
// Étranger (même viewer via partage simulé plus bas) → NOT_FOUND.
if err := s.CorrectFacts(viewer, fileID, nil); err != repository.ErrNotFound {
t.Fatalf("étranger : attendu NOT_FOUND, got %v", err)
}
// Absent → NOT_FOUND (EffectiveAccess sur ressource inconnue).
if err := s.CorrectFacts(owner, repository.NewID(), []FactDTO{correctDTO("issuer", "X")}); err != repository.ErrNotFound {
t.Fatalf("absent : attendu NOT_FOUND, got %v", err)
}
}
func TestSyncOpCorrectFacts(t *testing.T) {
s, ex := newExtractStore(t)
userID := mustCreateUser(t, s.Repository, "extract-op")
other := mustCreateUser(t, s.Repository, "extract-op-x")
device := mustRegisterDevice(t, s.Repository, "c0000000000000000000000000000001")
fileID := repository.NewID()
if err := s.Repository.Resources.InsertFile(userID, fileID, "facture.pdf", "", 0, nil, nil); err != nil {
t.Fatalf("insert: %v", err)
}
if err := ex.ProcessText(fileID, extractCorpus); err != nil {
t.Fatalf("process: %v", err)
}
foreignID := repository.NewID()
if err := s.Repository.Resources.InsertFile(other, foreignID, "autre.pdf", "", 0, nil, nil); err != nil {
t.Fatalf("insert foreign: %v", err)
}
apply := func(resID string, facts []FactDTO) SyncResult {
t.Helper()
raw := map[string]any{"facts": facts}
res, err := s.ApplyBatch(userID, device, []SyncOperation{
syncOp(repository.NewID(), resID, OpCorrectFacts, "file", raw),
})
if err != nil {
t.Fatalf("apply: %v", err)
}
return res
}
if res := apply(fileID, []FactDTO{correctDTO("issuer", "Corrigé")}); res.Applied != 1 || res.Failed != nil {
t.Fatalf("correct op: %+v", res)
}
facts, _ := s.GetFacts(userID, fileID)
found := false
for _, f := range facts {
if f.FactType == "issuer" && f.Origin == "user" && f.ValueText == "Corrigé" {
found = true
}
}
if !found {
t.Fatalf("correction via op manquante: %+v", facts)
}
// Op étrangère → halt NOT_FOUND.
if res := apply(foreignID, []FactDTO{correctDTO("issuer", "X")}); res.Failed == nil || res.Failed.Code != "NOT_FOUND" {
t.Fatalf("correct autrui doit halter NOT_FOUND: %+v", res)
}
// Payload invalide → halt INVALID_REQUEST.
res, err := s.ApplyBatch(userID, device, []SyncOperation{
syncOp(repository.NewID(), fileID, OpCorrectFacts, "file", map[string]any{
"facts": []any{map[string]any{"factType": "couleur", "valueText": "bleu"}},
}),
})
if err != nil {
t.Fatalf("apply: %v", err)
}
if res.Failed == nil || res.Failed.Code != "INVALID_REQUEST" {
t.Fatalf("payload invalide doit halter INVALID_REQUEST: %+v", res)
}
}