package service import ( "testing" "github.com/kazier/backend/repository" ) // V2-6 : partage vers un groupe — les membres voient la ressource // (snapshot + enforcement), les non-membres non. Révocation et suppression // du groupe convergent. func TestGroupShareSnapshotAndEnforcement(t *testing.T) { s := newServiceStore(t) ownerID := mustCreateUser(t, s.Repository, "grp-owner") memberID := mustCreateUser(t, s.Repository, "grp-member") outsiderID := mustCreateUser(t, s.Repository, "grp-outsider") deviceID := mustRegisterDevice(t, s.Repository, shareTestDeviceID) groupID, err := s.Repository.Groups.Create("Famille", ownerID) if err != nil { t.Fatalf("create group: %v", err) } if err := s.Repository.Groups.AddMember(groupID, memberID); err != nil { t.Fatalf("add member: %v", err) } fileID := repository.NewID() if _, err := s.ApplyBatch(ownerID, deviceID, []SyncOperation{ syncOp(repository.NewID(), fileID, OpCreateResource, "file", map[string]any{"name": "g.txt"}), syncOp(repository.NewID(), fileID, OpShare, "file", map[string]any{ "granteeGroupId": groupID, "access": "editor", }), }); err != nil { t.Fatalf("create+share-group: %v", err) } // Snapshot membre : rang editor hérité du groupe. perms, err := s.Snapshot(memberID, 0) if err != nil { t.Fatalf("Snapshot member: %v", err) } if len(perms) != 1 || perms[0].EffectiveAccess != "editor" { t.Fatalf("snapshot membre = %+v, attendu 1 editor", perms) } // Enforcement : le membre lit (GET file), l'outsider non. ra, err := s.Repository.Shares.EffectiveAccess(memberID, fileID) if err != nil || !ra.Accessible || ra.EffectiveRank != repository.AccessEditor { t.Errorf("EffectiveAccess membre = %+v err=%v, attendu editor", ra, err) } row, err := s.Repo.GetFileVisible(memberID, fileID) if err != nil || row.ID != fileID { t.Errorf("membre doit voir le fichier : %+v err=%v", row, err) } if _, err := s.Repo.GetFileVisible(outsiderID, fileID); err == nil { t.Errorf("outsider ne doit pas voir le fichier") } // Owner listing : grant kind=group au nom du groupe. grants, err := s.ListShares(ownerID, fileID) if err != nil || len(grants) != 1 { t.Fatalf("ListShares = %+v err=%v", grants, err) } if grants[0].GranteeKind != "group" || grants[0].GranteeUserID != groupID || grants[0].Username != "Famille" { t.Errorf("grant groupe = %+v", grants[0]) } // Retrait du membre → disparaît du snapshot au pull complet. if err := s.Repository.Groups.RemoveMember(groupID, memberID); err != nil { t.Fatalf("remove member: %v", err) } perms, err = s.Snapshot(memberID, 0) if err != nil { t.Fatalf("Snapshot après retrait: %v", err) } if len(perms) != 0 { t.Errorf("snapshot après retrait = %+v, attendu vide", perms) } // Suppression du groupe → plus de partage (cascade FK). member2 := mustCreateUser(t, s.Repository, "grp-member2") if err := s.Repository.Groups.AddMember(groupID, member2); err != nil { t.Fatalf("add member2: %v", err) } if _, err := s.ApplyBatch(ownerID, deviceID, []SyncOperation{ syncOp(repository.NewID(), fileID, OpShare, "file", map[string]any{ "granteeGroupId": groupID, "access": "viewer", }), }); err != nil { t.Fatalf("re-share: %v", err) } if err := s.DeleteGroup(ownerID, groupID); err != nil { t.Fatalf("delete group: %v", err) } perms, err = s.Snapshot(member2, 0) if err != nil { t.Fatalf("Snapshot après delete: %v", err) } if len(perms) != 0 { t.Errorf("snapshot après delete groupe = %+v, attendu vide", perms) } } func TestGroupShareValidation(t *testing.T) { s := newServiceStore(t) ownerID := mustCreateUser(t, s.Repository, "grpval-owner") deviceID := mustRegisterDevice(t, s.Repository, shareTestDeviceID) fileID := repository.NewID() if _, err := s.ApplyBatch(ownerID, deviceID, []SyncOperation{ syncOp(repository.NewID(), fileID, OpCreateResource, "file", map[string]any{"name": "v.txt"}), }); err != nil { t.Fatalf("create: %v", err) } apply := func(payload map[string]any) (SyncResult, error) { return s.ApplyBatch(ownerID, deviceID, []SyncOperation{ syncOp(repository.NewID(), fileID, OpShare, "file", payload), }) } // Groupe inconnu → GROUP_NOT_FOUND. denied, err := apply(map[string]any{"granteeGroupId": repository.NewID(), "access": "viewer"}) if err != nil || denied.Applied != 0 || denied.Failed == nil || denied.Failed.Code != "GROUP_NOT_FOUND" { t.Errorf("groupe inconnu: attendu halt GROUP_NOT_FOUND, got %+v err=%v", denied, err) } // Deux cibles → INVALID_REQUEST. both, err := apply(map[string]any{ "granteeUserId": ownerID, "granteeGroupId": repository.NewID(), "access": "viewer", }) if err != nil || both.Applied != 0 || both.Failed == nil || both.Failed.Code != "INVALID_REQUEST" { t.Errorf("deux cibles: attendu halt INVALID_REQUEST, got %+v err=%v", both, err) } // Aucune cible → INVALID_REQUEST. none, err := apply(map[string]any{"access": "viewer"}) if err != nil || none.Applied != 0 || none.Failed == nil || none.Failed.Code != "INVALID_REQUEST" { t.Errorf("sans cible: attendu halt INVALID_REQUEST, got %+v err=%v", none, err) } } func TestGroupManagementScoping(t *testing.T) { s := newServiceStore(t) ownerID := mustCreateUser(t, s.Repository, "gm-owner") otherID := mustCreateUser(t, s.Repository, "gm-other") memberID := mustCreateUser(t, s.Repository, "gm-member") group, err := s.CreateGroup(ownerID, " Équipe ") if err != nil { t.Fatalf("create: %v", err) } if group.Name != "Équipe" || group.Role != "owner" { t.Errorf("groupe = %+v (nom trimé attendu)", group) } if _, err := s.CreateGroup(ownerID, " "); err == nil { t.Errorf("nom vide attendu rejeté") } // Non-owner ne peut ni ajouter ni supprimer. if err := s.AddGroupMember(otherID, group.ID, memberID); err == nil { t.Errorf("add par non-owner attendu refusé") } if err := s.AddGroupMember(ownerID, group.ID, memberID); err != nil { t.Fatalf("add: %v", err) } // Membre inexistant → GRANTEE_NOT_FOUND. if err := s.AddGroupMember(ownerID, group.ID, repository.NewID()); err != repository.ErrGranteeNotFound { t.Errorf("membre inconnu: attendu ErrGranteeNotFound, got %v", err) } if err := s.RemoveGroupMember(otherID, group.ID, memberID); err == nil { t.Errorf("remove par non-owner attendu refusé") } // Listes : owner voit (owner), membre voit (member), tiers ne voit rien. owned, _ := s.ListGroups(ownerID) if len(owned) != 1 || owned[0].Role != "owner" { t.Errorf("list owner = %+v", owned) } joined, _ := s.ListGroups(memberID) if len(joined) != 1 || joined[0].Role != "member" { t.Errorf("list member = %+v", joined) } none, _ := s.ListGroups(otherID) if len(none) != 0 { t.Errorf("list tiers = %+v, attendu vide", none) } if err := s.DeleteGroup(otherID, group.ID); err == nil { t.Errorf("delete par non-owner attendu refusé") } if err := s.DeleteGroup(ownerID, group.ID); err != nil { t.Fatalf("delete: %v", err) } }